Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Option to disable isAtBottom #128

Open
hrishikesh-k opened this issue Jun 13, 2021 · 0 comments
Open

[Feature request] Option to disable isAtBottom #128

hrishikesh-k opened this issue Jun 13, 2021 · 0 comments

Comments

@hrishikesh-k
Copy link

Hi!

Thanks for the great library, works amazingly.

I do have a small request though and would be very thankful if it's taken into consideration and implemented. It's a personal opinion, so others might feel differently.

According to me, the isAtBottom() part should be a configurable option. This is because, in its current implementation, it directly skips over a lot of list items. For example, I'm working on a documentation website and in that, I've a lot of headings with small descriptions. Thus, till the extreme end the headings are correctly highlighted, however as soon as document reaches the end, the list items skip over many headings and jumps to the last one. To me, this feels like a glitch rather than a feature.

For example, in this image, the highlighted item before isAtBottom() is form:

image

But as soon as you scroll a pixel down to reach the end, it jumps to title skipping the 3 others in between. I'd rather prefer if it doesn't do that and highlight the one according to the top offset like it does for other headings.

I understand that others might think differently and thus, adding this as a configuration option makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant