Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier lookup #3

Merged
merged 16 commits into from
May 29, 2013
Merged

Conversation

KennethSundqvist
Copy link
Contributor

The focus of these changes are to make looking things up easier and faster.

To summarise the changes:

  • Open/Close the CanIUse panel with the "Ctrl-Alt-U" keyboard shortcut.
  • Filter on the selected text if any and focus the filter field when opening the panel.
  • Updated design of the filter and feature list column.
  • Fix a bug where data was loaded each time the panel was opened, causing duplicate entries in the feature list.
  • Hide category titles when there are no matches in the category.
  • Keyboard navigation for filter and feature list; Tab/Shift-tab or Up/Down or J/K.
  • Trim the filter value from whitespace at its beginning and end.

@cfjedimaster
Copy link
Owner

My god - an amazing amount of work. EvilOatmeal (great nic btw) - thank you!

cfjedimaster added a commit that referenced this pull request May 29, 2013
@cfjedimaster cfjedimaster merged commit 29cb8e0 into cfjedimaster:master May 29, 2013
@cfjedimaster
Copy link
Owner

Oh oh - I'm seeing some 'bleeding' of the drop down. See:

https://www.evernote.com/shard/s3/sh/55abe7e0-7987-4990-82cf-af5b1c6a1740/5cbbb426869d7a7727191aaa84ffcd8c

@cfjedimaster
Copy link
Owner

I should note that when I resized the bottom panel it went away, so it may be an issue just at smaller sizes.

@KennethSundqvist
Copy link
Contributor Author

I cannot reproduce the 'bleeding' bug. Which version of Brackets are you using? I am using Sprint 25 Official OS X package.

@cfjedimaster
Copy link
Owner

So am I. I had greatly increased the font size for a preso. Maybe that was part of it. I can't recreate it now so I think you can ignore.

@KennethSundqvist KennethSundqvist deleted the easier-lookup branch May 30, 2013 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants