Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore improperly ignores all files starting with **plugin** (affects all branches) #49

Closed
neoh4x0r opened this issue Aug 17, 2022 · 1 comment

Comments

@neoh4x0r
Copy link

neoh4x0r commented Aug 17, 2022

All branches (v2, v1, etc) has the following in .gitingore:

plugin.*
dist/
build/

This results in the following files being ignored (they aren't included in a checkout/clone)

  • /plugin.json
  • /src/plugin.cpp
  • /src/plugin.hpp

I believe the intention was to ignore plugin.so and plugin.dll

So the contents of .gitingore should be

plugin.so
plugin.dll
dist/
build/
@neoh4x0r
Copy link
Author

neoh4x0r commented Feb 11, 2023

This was fixed in 9509b74
(it won't ingore plugin.json any more, but should still be updated to ignore plugin.so, plugin.dll, plugin.dylib)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant