This repository has been archived by the owner on May 14, 2018. It is now read-only.
Fix unit tests and configure tox/Travis #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added use of setuptools-git-version in 51bb37c to better define package versions - thanks @rosskarchner. |
|
Changes Unknown when pulling d75cbdd on fix-tests into ** on master**. |
rosskarchner
approved these changes
Mar 21, 2017
| python: 2.7 | ||
| - env: TOXENV=py27-dj110 | ||
| python: 2.7 | ||
| - env: TOXENV=py35-dj18 |
There was a problem hiding this comment.
I wonder what the right answer is for testing against 3.x Python's. My machine doesn't have 3.5, for example (i have 3.6 via Homebrew)
There was a problem hiding this comment.
Good question. I have 3.5 via Homebrew. We can try to standardize against a Python 3 version - I know right now wagtail-flags and wagtail-sharing use Python 3.5, but that might be due to an arbitrary choice as opposed to a deliberate selection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unit tests in
hud_api_replace.testswhich referenced a bunch of long-since-deprecated Google Geocoder code. It also sets up atox.iniand.travis.ymlthat allows for testing against Python 2 & 3 and Django 1.8 & 1.10.To run the full unit test matrix:
To run against a specific version:
$ tox -e py27-dj18 .............................................................. ---------------------------------------------------------------------- Ran 62 tests in 0.046s OKThere's also a
flake8environment which can be run by invokingtox flake8but there are currently numerous errors; those fixes are out of scope for this PR.As part of these fixes this PR also moves existing migrations from South to Django; legacy databases will need to be migrated with
manage.py migrate --fake-initial.