-
Notifications
You must be signed in to change notification settings - Fork 33
Fix unit tests and configure tox/Travis #16
Conversation
Also added use of setuptools-git-version in 51bb37c to better define package versions - thanks @rosskarchner. |
Changes Unknown when pulling d75cbdd on fix-tests into ** on master**. |
python: 2.7 | ||
- env: TOXENV=py27-dj110 | ||
python: 2.7 | ||
- env: TOXENV=py35-dj18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what the right answer is for testing against 3.x Python's. My machine doesn't have 3.5, for example (i have 3.6 via Homebrew)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I have 3.5 via Homebrew. We can try to standardize against a Python 3 version - I know right now wagtail-flags and wagtail-sharing use Python 3.5, but that might be due to an arbitrary choice as opposed to a deliberate selection.
This PR fixes the unit tests in
hud_api_replace.tests
which referenced a bunch of long-since-deprecated Google Geocoder code. It also sets up atox.ini
and.travis.yml
that allows for testing against Python 2 & 3 and Django 1.8 & 1.10.To run the full unit test matrix:
To run against a specific version:
$ tox -e py27-dj18 .............................................................. ---------------------------------------------------------------------- Ran 62 tests in 0.046s OK
There's also a
flake8
environment which can be run by invokingtox flake8
but there are currently numerous errors; those fixes are out of scope for this PR.As part of these fixes this PR also moves existing migrations from South to Django; legacy databases will need to be migrated with
manage.py migrate --fake-initial
.