Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library should default to returning cached cell formula values instead of always recalculating #359

Closed
cfsimplicity opened this issue Feb 10, 2024 · 5 comments

Comments

@cfsimplicity
Copy link
Owner

See #358

There is now a setReturnCachedFormulaValues() switch to control this but it defaults to false currently. Defaulting to true is best though as it is clearly more performant, and avoids formula evaluation issues (sometimes POI cannot handle formulas that work fine in Excel).

This is a potentially breaking change though so only implement at the next major release.

@Daemach
Copy link

Daemach commented Mar 5, 2024

Has this change been merged into production? I did a full reinstall today and I'm getting the following error with 3.12.0

component [modules.spreadsheet-cfml.Spreadsheet] has no function with name [setReturnCachedFormulaValues]

@cfsimplicity
Copy link
Owner Author

No, as you'll see from the labels this is a breaking change that will be released in version 4.0. Hopefully coming soon.

@Daemach
Copy link

Daemach commented Mar 6, 2024

Did anything major change, especially java-related, in the dev branch around 2/9? I downloaded that when you asked me to test the setReturnCachedFormulaValues functionality.

Spreadsheet-cfml no longer works with the Pusher java components. We're trying to figure out where the conflict is now, but if I comment out pusher, spreadsheets work fine. If I comment out spreadsheets, pusher runs fine. Together we get bizarre messages such as the one below.
image
image

@cfsimplicity
Copy link
Owner Author

No, there were only minor code changes between the 3.12.0 release (November) and the develop version on 9 Feb. No lib/dependency changes.

I'm not familiar with Pusher I'm afraid.

Are you trying to use the 4.0 version of the spreadsheet lib just released?

@Daemach
Copy link

Daemach commented Mar 6, 2024

I didn't know it was released... We will try that next.

https://pusher.com/
https://github.com/pusher/pusher-websocket-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants