-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error displayed when do a cache log #6682
Comments
i have the same issue, worked yesterday, does not work today. Version of c:geo used: 2017.07.24 Is the problem reproducible for you? Yes, occurs everytime. Interestingly, when I kept trying to submit, after the first found log, it changed to a dnf log for each of the 8 or so times I tried after, before i checked and saw what happened. Yes/No System information: |
the geocaching.com server was off during that time, therefore this might be connected to just the server not available. https://twitter.com/GoGeocaching/status/897251827212746754 Can someone recheck this now? |
Confirmed with latest nightly! Error message in c:geo as shown above but logging is OK on the website. |
Here is a debug log (when debug logging is active, c:geo is also crashing while trying to post the log).
Removed blank lines -- SammysHP |
Posted problem info on social networks. |
Notification in c:geo posted. |
On the website I see indeed some layout changes which might affect our login check or something else during the logging procedure. The old logging page however is still available, so it is likely not related to #6519. I guess some content has changed which makes us fail to detect, that the user is logged in, which then triggers the normal login procedure (which seems to work normal so far). |
@Bananeweizen Are you able to look into this problem? If the problem does not vanish in the next hours (which would mean it is probably not caused by a website problem) we might need to get a fixed version out as soon as possible :( |
As the problem is still there, I added a FAQ entry and warning on homepage and modified the notification in c:geo accordingly (linked to FAQ). |
Additional info from user via FB: |
Right now we discovered that the webpage is back to the old design/HTML. As according to @kumy his change in #6685 should be compatible with both styles, I tested the scenario of new code (RC version from release branch) with old design/HTML:
Let us keep the change on release branch for now and wait and see what happens next. If the site keeps rolled back the next hours I will remove or modify the notification, etc. |
For the record, the changed part was a new class added Here is what we get during this day...
|
Status today 9am UTC: |
Notification has been updated (..."might sporadically fail...") and I did another posting on FB "currently no more problem" |
Just tested and it sill looks normal. |
Fix from #6685 needs to be ported to master. Current builds of master fail with:
http://ci.cgeo.org/job/cgeo%20continuous%20integration/1687/console |
But last days I repeatedly tested and could not see this (logging) issue using current master/nightly. |
I was rather talking about the "could not find home coordinates"
…On August 19, 2017 7:13:43 PM GMT+02:00, Lars ***@***.***> wrote:
But last days I repeatedly tested and could not see this (logging)
issue using current master/nightly.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6682 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
@pstorch exactly. Both commits.
…On August 19, 2017 10:24:54 PM GMT+02:00, Peter Storch ***@***.***> wrote:
@kumy are you talking about the commit
ebc9c42 only or also
78fd083?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6682 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
We could cherry pick only those two, but would then always cherry pick from release to master. I think we should revert the one unwanted commit to be able to regularly merge from release to master. What do you think? |
Ok for me to revert the third then merge.
…On August 20, 2017 7:42:55 AM GMT+02:00, Peter Storch ***@***.***> wrote:
We could cherry pick only those two, but would then always cherry pick
from release to master. I think we should revert the one unwanted
commit to be able to regularly merge from release to master. What do
you think?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6682 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
I've reverted 9ea91e3 and merged |
Exact. |
There are reports on the "Geocaching UK" FB group that this problem has re-appeared. |
I can confirm the problem is back - just reproduced it myself. |
@Lineflyer should we re-enable 9ea91e3, maybe in master and release a NB/Beta? @alan666notb may you please send us html code for the login status from the top bar when you are on the login page? Mine is:
|
Is this any use?
|
@alan666notb Thanks. I can't build anything until tonight. We should verify 9ea91e3, but I think it should work. |
@Lineflyer I have re-played notification job to enable the warning again. |
Confirmed, the problem is there again also for me (and from support mail). Might also be related to #6702 |
+1 for the relation with #6702 |
@kumy Feel free to provide a fix proposal on release branch as soon as you have time for it. |
For the records, here is how the old page looked like:
|
Beta version with fix published. Notification modified to be shown for all versions except RC and nightly. |
Detailed steps causing the problem:
It begin to appear, after new Geocaching.com layout.
Expected behavior after performing these steps:
Version of c:geo used:
Is the problem reproducible for you?
Yes/No
System information:
Other comments and remarks:
e.g. Reference to other issues, projects, sources, etc.
The text was updated successfully, but these errors were encountered: