Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selected position info #15571

Merged
merged 1 commit into from Apr 8, 2024

Conversation

moving-bits
Copy link
Member

Description

Implements the ideas described in #15429 (comment):

  • Combines map long-tap menu entries for "Show coordinates" and "Elevation (map)" into a single "Selected position" entry
  • Tapping on it opens a dialog with following options:
    • Display coordinates (format switchable)
    • Display elevation from map
    • Display distance to current position (straight line)

image

Closes #15429

@moving-bits moving-bits self-assigned this Apr 7, 2024
@moving-bits
Copy link
Member Author

failing tests are unrelated

@ztNFny
Copy link
Contributor

ztNFny commented Apr 8, 2024

Thanks for taking care of this, I just didn't have the time for this yet.
One thing I had in mind was adding icons to the dialog (maybe instead of the text, not sure, have to try it) - I can take care of that after this PR.

@moving-bits moving-bits merged commit 47ba340 into cgeo:release Apr 8, 2024
1 of 2 checks passed
@moving-bits moving-bits deleted the selectedPosition branch April 8, 2024 19:21
@ztNFny
Copy link
Contributor

ztNFny commented Apr 8, 2024

Text alignment is broken. It's right-aligned to the widest text, not the.dialog

IMG_20240408_212547.jpg

Screenshot_2024-04-08-21-25-19-25_a916ceb0c8a82619faeb76fe6b8ae997.jpg

@moving-bits
Copy link
Member Author

This was intentional, as having text/values unaligned looked pretty ugly, and having them aligned to the dialog's borders made them being very far apart from each other, looking unrelated.

(But this could be changed, if preferred, or even won't happen at all if we switch to icons instead of text. The last two lines could then be put into a single line.)

@moving-bits
Copy link
Member Author

@ztNFny
Maybe something like this?

image

(is a hand-crafted bitmap for now)

maybe skip the little separator dot between elevation and distance?

@ztNFny
Copy link
Contributor

ztNFny commented Apr 8, 2024

This was intentional, as having text/values unaligned looked pretty ugly, and having them aligned to the dialog's borders made them being very far apart from each other, looking unrelated.

ok, I'll try to come up with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants