Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condensed position info with icons #15583

Merged
merged 1 commit into from Apr 13, 2024
Merged

Condensed position info with icons #15583

merged 1 commit into from Apr 13, 2024

Conversation

moving-bits
Copy link
Member

Description

as discussed in #15571:

image

  • removed right-alignment of elevation and distance info
  • replaced text by our assigned icons for elevation / straight distance

@moving-bits moving-bits self-assigned this Apr 10, 2024
@moving-bits
Copy link
Member Author

failing tests are unrelated

@ztNFny
Copy link
Contributor

ztNFny commented Apr 10, 2024

You have to give me some time! 🤪
Could pick up #15566 and add a "vertical distance" to the dialog as well. Suitable icon would be https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Aheight%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4024

Layout suggestion:
Coordinates
Distance - Vertical distance
Elevation

Could you add tooltips to those textviews please?

@moving-bits
Copy link
Member Author

moving-bits commented Apr 10, 2024 •
edited

vertical distance would be "map elevation at selected position" - "map elevation at current position" (allowing negative numbers)?

Will add the icon (thanks for looking it up) and tooltips.

You have to give me some time! 🤪

Sorry, I had it already 90% done for the screenshot yesterday, so I thought I can finish it just as well to avoid doubled work.

@ztNFny
Copy link
Contributor

ztNFny commented Apr 10, 2024

Maybe also a compass icon in front of the coordinates? That'd provide a place for the tooltip as well,
Not sure we already have one, if not:
https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Aexplore%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4024

@moving-bits
Condensed position info with icons
d7f0986 
- replaced text with icons for distance and elevation info
- added compass rose icon for coordinate info
- added elevation difference between current position and selected position
@moving-bits
Copy link
Member Author

new version: (with an active tooltip)

image

@moving-bits moving-bits merged commit 9320564 into cgeo:release Apr 13, 2024
1 of 2 checks passed
@moving-bits moving-bits deleted the selected_position_info branch April 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moving-bits moving-bits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moving-bits @ztNFny