Update to compileSdkVersion 24 (Fix #7257) #7287

bekuno · 2019-02-10T21:18:34Z

Update compileSdkVersion to "Google Inc.:Google APIs:24" and appcompat Libraries to '24.2.1'.
Using the old form of compileSdkVersion because of google maps v1 compatibility.
This is the latest version supporting google maps v1.

bekuno · 2019-02-10T21:28:26Z

This PR supersedes PR #7266.

moving-bits · 2019-02-11T12:12:54Z

from Jenkins error log:

22:19:40  Checking the license for package Android SDK Platform 24 in /opt/android-sdk-linux/licenses
22:19:40  Warning: License for package Android SDK Platform 24 not accepted.
22:19:40  Checking the license for package Google APIs in /opt/android-sdk-linux/licenses
22:19:40  Warning: License for package Google APIs not accepted.
22:19:41  
22:19:41  
FAILURE: Build failed with an exception.
22:19:41  
22:19:41  * What went wrong:
22:19:41  A problem occurred configuring project ':main'.
22:19:41  > Failed to install the following Android SDK packages as some licences have not been accepted.
22:19:41       platforms;android-24 Android SDK Platform 24
22:19:41       add-ons;addon-google_apis-google-24 Google APIs
22:19:41    To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager.
22:19:41    Alternatively, to transfer the license agreements from one workstation to another, see http://d.android.com/r/studio-ui/export-licenses.html

bekuno · 2019-02-11T20:40:56Z

@kumy Are you responsible for configuring the build environment (new SDK packages, accept license)?

kumy · 2019-02-11T20:43:49Z

@bekuno I'll check…

kumy · 2019-02-11T20:48:12Z

We use sdkmanager to accept the licenses during install in the docker image.

https://github.com/cgeo/cgeo-executor/blob/0be17aa820d50624b16a87a323730960b9dd1387/Dockerfile#L36

kumy · 2019-02-11T20:50:06Z

I need to build new images including right packages https://github.com/cgeo/cgeo-executor/blob/master/android-packages. @bekuno any idea on the exact names needed here?

Info was in the logs:

22:19:41 platforms;android-24 Android SDK Platform 24
22:19:41 add-ons;addon-google_apis-google-24 Google APIs

Add android platform 24 as requested per cgeo/cgeo#7287

Related to cgeo/cgeo#7287

Add android platform 24 as requested per cgeo/cgeo#7287

kumy · 2019-02-11T21:10:29Z

New build in progress: http://ci.cgeo.org/job/cgeo%20pull%20request/1613/console

kumy · 2019-02-11T21:13:28Z

Jenkins: retest this please

kumy · 2019-02-11T21:24:38Z

Test is working, so now I need to really build the image and update the executors. But also need to update master node (tomorrow).

rsudev · 2019-02-11T21:26:28Z

Thanks @kumy for chiming in so quickly!

bekuno · 2019-02-11T21:27:47Z

@kumy Many thanks for the quick customization.

kumy · 2019-02-12T20:01:05Z

master node has now the new packages and others were updated

$ sdkmanager "add-ons;addon-google_apis-google-24" "build-tools;28.0.3" "platforms;android-24"
$ sdkmanager --update

Current list of packages on master:

  Path                                | Version | Description                    | Location                            
  -------                             | ------- | -------                        | -------                             
  add-ons;addon-google_apis-google-23 | 1       | Google APIs                    | add-ons/addon-google_apis-google-23/
  add-ons;addon-google_apis-google-24 | 1       | Google APIs                    | add-ons/addon-google_apis-google-24/
  build-tools;23.0.3                  | 23.0.3  | Android SDK Build-Tools 23.0.3 | build-tools/23.0.3/                 
  build-tools;25.0.2                  | 25.0.2  | Android SDK Build-Tools 25.0.2 | build-tools/25.0.2/                 
  build-tools;26.0.2                  | 26.0.2  | Android SDK Build-Tools 26.0.2 | build-tools/26.0.2/                 
  build-tools;27.0.3                  | 27.0.3  | Android SDK Build-Tools 27.0.3 | build-tools/27.0.3/                 
  build-tools;28.0.3                  | 28.0.3  | Android SDK Build-Tools 28.0.3 | build-tools/28.0.3/                 
  emulator                            | 28.0.23 | Android Emulator               | emulator/                           
  extras;android;m2repository         | 47.0.0  | Android Support Repository     | extras/android/m2repository/        
  extras;google;m2repository          | 58      | Google Repository              | extras/google/m2repository/         
  patcher;v4                          | 1       | SDK Patch Applier v4           | patcher/v4/                         
  platform-tools                      | 28.0.1  | Android SDK Platform-Tools     | platform-tools/                     
  platforms;android-23                | 3       | Android SDK Platform 23        | platforms/android-23/               
  platforms;android-24                | 2       | Android SDK Platform 24        | platforms/android-24/               
  tools                               | 26.1.1  | Android SDK Tools              | tools/

That's all for me here. Good luck :)

Lineflyer · 2019-02-17T16:31:21Z

This PR supersedes PR #7266.

Does this mean #7266 can be considered obsolete. If so, please kindly close it, so we clean up the open PRs a little bit to see what needs to be merged.

rsudev · 2019-02-17T18:05:11Z

Retest this please

bekuno · 2019-02-17T21:16:59Z

@rsudev Should kumy rewind the changes from today morning?

rsudev · 2019-02-18T20:59:04Z

@kumy @bekuno As far as I could see did the updated build image work until the website changes started (sometimes test failures can lead to follow up issues in the build process it seems),
so I would suggest to give the updated version another try.

kumy · 2019-02-18T21:00:20Z

I'll relaunch executors on v2.0.2 image.

kumy · 2019-02-18T21:03:15Z

Executors are now up-to-date :) Enjoy!

rsudev · 2019-02-18T21:05:59Z

Retest this please

rsudev · 2019-02-18T21:49:09Z

@kumy Thanks! Looks like both, new compile sdk (this PR) as well as old (e.g. #7308) are working now!

kumy · 2019-02-18T21:51:49Z

Hum, I don't know why jenkins didn't reported the errors here, test result should be failed, no?

22:14:15  09:14:19 V/InstrumentationResultParser: FAILURES!!!
22:14:15  09:14:19 V/InstrumentationResultParser: Tests run: 449,  Failures: 2

http://ci.cgeo.org/job/cgeo%20pull%20request/1638/console

rsudev · 2019-02-19T06:43:09Z

Very good point. The failures you mention come from the instrumentation step (not sure what this is about) but later on you can see that the test build failed completely (so no tests were run).
Looks like there is a need to check some more things.
Very weird that e.g. build 1641 reports all tests as green, in spite of having the same compilation problem...

Update compileSdkVersion to "Google Inc.:Google APIs:24" and appcompat Libraries to '24.2.1'. Using the old form of compileSdkVersion because of google maps v1 compatibility.

Lineflyer · 2019-02-22T19:00:23Z

lets keep this change on hold until after first upcoming release please.

…r PR cgeo#7287 - remove using the SupportLibrary - remove obsolete buildToolsVersion entry

bekuno changed the title ~~Fix #7257~~ Update to compileSdkVersion 24 (Fix #7257) Feb 10, 2019

kumy added a commit to cgeo/cgeo-executor that referenced this pull request Feb 11, 2019

Add platforms;android-24

207d7c2

Add android platform 24 as requested per cgeo/cgeo#7287

kumy mentioned this pull request Feb 11, 2019

Add platforms;android-24 cgeo/cgeo-executor#12

Merged

kumy added a commit to cgeo/cgeo-executor that referenced this pull request Feb 11, 2019

Add addon-google_apis-google-24

865f61c

Related to cgeo/cgeo#7287

kumy added a commit to cgeo/cgeo-executor that referenced this pull request Feb 11, 2019

Add platforms;android-24

080f6e0

Add android platform 24 as requested per cgeo/cgeo#7287

kumy mentioned this pull request Feb 17, 2019

Change the compile pattern after change on the GC.com page (Fix #7291) #7295

Merged

rsudev mentioned this pull request Feb 17, 2019

align all android support libraries to version 23.4.0 #7266

Closed

Fix cgeo#7257

53f7f24

Update compileSdkVersion to "Google Inc.:Google APIs:24" and appcompat Libraries to '24.2.1'. Using the old form of compileSdkVersion because of google maps v1 compatibility.

bekuno force-pushed the Arrow_icon_indicating_submenu_no_longer_shown branch from 7af34ae to 53f7f24 Compare February 21, 2019 21:30

bekuno changed the base branch from master to release February 21, 2019 21:44

bekuno mentioned this pull request Feb 22, 2019

Next release #7174

Closed

bekuno added a commit to bekuno/cgeo that referenced this pull request Feb 23, 2019

- set compileSdkVersion and appcompat Library according to version fo…

fe6ae9d

…r PR cgeo#7287 - remove using the SupportLibrary - remove obsolete buildToolsVersion entry

UniQP merged commit 03e2677 into cgeo:release Feb 23, 2019

bekuno deleted the Arrow_icon_indicating_submenu_no_longer_shown branch February 25, 2019 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to compileSdkVersion 24 (Fix #7257) #7287

Update to compileSdkVersion 24 (Fix #7257) #7287

bekuno commented Feb 10, 2019

bekuno commented Feb 10, 2019

moving-bits commented Feb 11, 2019 •

edited by kumy

bekuno commented Feb 11, 2019

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019 •

edited

kumy commented Feb 11, 2019 •

edited

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019

rsudev commented Feb 11, 2019

bekuno commented Feb 11, 2019

kumy commented Feb 12, 2019

Lineflyer commented Feb 17, 2019

rsudev commented Feb 17, 2019

bekuno commented Feb 17, 2019

rsudev commented Feb 18, 2019

kumy commented Feb 18, 2019

kumy commented Feb 18, 2019

rsudev commented Feb 18, 2019

rsudev commented Feb 18, 2019

kumy commented Feb 18, 2019

rsudev commented Feb 19, 2019

Lineflyer commented Feb 22, 2019

Update to compileSdkVersion 24 (Fix #7257) #7287

Update to compileSdkVersion 24 (Fix #7257) #7287

Conversation

bekuno commented Feb 10, 2019

bekuno commented Feb 10, 2019

moving-bits commented Feb 11, 2019 • edited by kumy

bekuno commented Feb 11, 2019

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019 • edited

kumy commented Feb 11, 2019 • edited

kumy commented Feb 11, 2019

kumy commented Feb 11, 2019

rsudev commented Feb 11, 2019

bekuno commented Feb 11, 2019

kumy commented Feb 12, 2019

Lineflyer commented Feb 17, 2019

rsudev commented Feb 17, 2019

bekuno commented Feb 17, 2019

rsudev commented Feb 18, 2019

kumy commented Feb 18, 2019

kumy commented Feb 18, 2019

rsudev commented Feb 18, 2019

rsudev commented Feb 18, 2019

kumy commented Feb 18, 2019

rsudev commented Feb 19, 2019

Lineflyer commented Feb 22, 2019

moving-bits commented Feb 11, 2019 •

edited by kumy

kumy commented Feb 11, 2019 •

edited

kumy commented Feb 11, 2019 •

edited