Change the compile pattern after change on the GC.com page (Fix #7291) #7295
Conversation
Change the compile pattern after change on the GC.com page
|
@kumy Currently all new builds are breaking at different stages, even those which only have changed some layout xml (see the last four PR). Could you have a look at Jenkins, pls? Thx. |
|
This one failed,as the stored test data does no longer fit the new site layout. I am looking into it. |
|
I'm not available today :( will check or rollback in the evening.
My idea in the past was to build on each android version, but from memory only the emulator running on android 23 was working fine (it was some month ago). I hope upgrading the tooling around didn't break things. @rsudev, does master node works as expected? It has been updated too.
|
|
I've found a moment before leaving, I've rollbacked the docker images to v2.0.1, hope this help at some point. |
|
Jenkins: please test this |
|
Hum, wrong keyword… Jenkins: retest this please |
|
FTR, #7287 (comment) the job referenced here, is Green, but in fact has failed :( - Banging my head on the table - |
|
Jenkins: retest this please |
|
I have to leave now, I've also issued a manual upgrade of build-tools in the containers: Tests jobs: |
|
Ja
kumy <notifications@github.com> schrieb am So., 17. Feb. 2019, 11:21:
… I have to leave now, I've also issued a manual upgrade of build-tools in
the containers: sdkmanager "build-tools;28.0.3"
Tests jobs:
- http://ci.cgeo.org/job/cgeo%20pull%20request/1623/console
- http://ci.cgeo.org/job/cgeo%20pull%20request/1622/console
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHa6NPDnmF3raQ5i3UcGZ2QLmdZZ3Bhzks5vOS0pgaJpZM4a-9KD>
.
|
|
"Ja"?
|
|
@rsudev just read your last comment carefully, did you mean rollback was not necessary and problems came all from new GC website design? |
I would also say so. We have some dumped cache pages in our tests to test the parsing. Of course these might need to be adapted as soon as parsing rules are changed. |
|
But AFAICS the tests also show another problem which need to be fixed for trackables. I will open a dedicated issue for that. |
|
Two tests fixed by trackable fix and test data adaption:
Three tests fail now:
ad 1): Unclear, need to investigate ad 2): Triggered by the change in test data, very unclear to me, it should work as before... ad 3): Triggered by the trackable fix, need to adapt test data |
- adaption of test data needed
|
@kumy regarding the build problems - I am unsure but had the impression from scanning the build logs. Unfortunately did I still no manage to get my node up-and-running, so I cannot cross-check right now. |
|
Any action needed from my side today? |
#7295) * Fixes: Cache descriptions showing blank #7291 Change the compile pattern after change on the GC.com page * Fix trackable pattern after website change * Adpat test data after website change * Fix test reference data * Disable testParseSpeedManagerCompressedTrackable - adaption of test data needed
Fixes: Cache descriptions showing blank #7291
Change the compile pa ttern after change on the GC.com page