Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send2cgeo Firefox add-on #8

Closed
Lineflyer opened this issue Jun 26, 2015 · 17 comments
Closed

send2cgeo Firefox add-on #8

Lineflyer opened this issue Jun 26, 2015 · 17 comments
Labels

Comments

@Lineflyer
Copy link
Member

From @JavaJens on August 2, 2013 12:32

Hi,

is there a reason why there is no Firefox AddOn?
The idea I have is to remove the need for Greasemonkey, as I find this to be cumbersome for novice users.

It would be fairly simple to do this, 5 lines with the AddOn builder and page-mod.
Though, one possible issue I see with this is the update mechanism, as for each change of the script the addon would need to be updated as well, but then Firefox would update the app automatically.

Furthermore I have one off-topic question, is the server side code for send2cgeo publicly available as well?

Looking forward for feedback.

Copied from original issue: cgeo/cgeo#3094

@Lineflyer
Copy link
Member Author

From @SammysHP on August 2, 2013 18:48

Ahh, seems that you want to maintain the AddOn, thank you! :) Can you send us an example?

Furthermore I have one off-topic question, is the server side code for send2cgeo publicly available as well?

Not yet.

@Lineflyer
Copy link
Member Author

It would really be nice to use it directly with Firefox. Feel free to contribute if you have ideas of the implementation.

@Lineflyer
Copy link
Member Author

From @JavaJens on August 3, 2013 10:9

I wouldn't mind.
Prior to contributing though I want to make sure I understand the requirements license. Is it enough to package the NOTICE and LICENSE file with the addon?

Should I then upload the addon to http://addons.mozilla.org/ and create a pull request with the source code?

@Lineflyer
Copy link
Member Author

From @Bananeweizen on August 3, 2013 11:9

Great. Thanks for supporting us, as we are still a small group of developers and don't have knowledge in each area!

To my understanding, it is even enough to have the LICENSE file together with the add on source code. You may want to read the Wikipedia entry in your language about the Apache license.

I'm not sure about the order of things: Maybe we want to redo something in the pull request (e.g. changing some strings to match often used terms in c:geo or the like), therefore I think it might be easier to have the pull request first and to upload the add-on after successful merge.

And just in case you are German: It is fine to ask complicated questions like the licensing stuff in German, as we can translate.

@Lineflyer
Copy link
Member Author

From @JavaJens on August 3, 2013 11:37

Was my english this pitiful ;)
I will create the pull request and then you can decide about the next steps.

Furthermore would I like to include an icon, under what terms are the images on http://send2.cgeo.org/ released?

@Lineflyer
Copy link
Member Author

From @Bananeweizen on August 3, 2013 11:49

Same license, Apache 2.0. Should you need a large scale version of the logo, that is also in the main repository at https://github.com/cgeo/cgeo/blob/master/main/project/rawimages/c_geo_icon_512.png. Even an SVG version can be found there, if needed: https://github.com/cgeo/cgeo/blob/master/main/project/rawimages/c-geo_icon.svg

@Lineflyer
Copy link
Member Author

A question regarding to this:
Do we need a transistion phase between those two addon methods (direct and greasemonkey)?
Or do we keep both versions alive?

@Lineflyer
Copy link
Member Author

From @Bananeweizen on August 10, 2013 8:6

We need both, as far as I understand. Because the JetPack addon does not work in Chrome, but the userscript itself works in Chrome (via TamperMonkey).

@Lineflyer
Copy link
Member Author

From @JavaJens on August 10, 2013 8:48

Yes, plus there might be people who already use Greasemonkey. Therefore there would be no need for them to switch.

@Lineflyer
Copy link
Member Author

@JavaJens Any news on this?

@Lineflyer
Copy link
Member Author

From @JavaJens on June 2, 2014 19:47

I haven't looked into this recently as interest seamed to have faded.
But I could easily pick up work again.

@Lineflyer
Copy link
Member Author

My personal opinion is, that it might be the right time to place the script into the official stores of Firefox and Google-
Google is just started to ban all 3rd party scripts.

@Lineflyer
Copy link
Member Author

From @JavaJens on June 4, 2014 18:4

So what is actually needed for that?
Should the plugin contain only the Geocaching.com script or also for the other sites?

@Lineflyer
Copy link
Member Author

From @Bananeweizen on June 5, 2014 12:19

I recommend to only have one plugin. There is no benefit (not even easier maintenance), if we split that into several plugins.

@Lineflyer
Copy link
Member Author

I would also suggest to have one script for all caching websites.

@Lineflyer
Copy link
Member Author

From @JavaJens on June 12, 2014 20:48

I'd be more than happy to provide a packaged extension for testing! Just tell me whom and how to send them....
For chrome you have to use the unpackaged version from the Repo....
I've updated my fork to incorporate support for all three scripts

@Lineflyer
Copy link
Member Author

No more work was done here and we are quite well working with Greasemonkey.
Closing. Feel free to reopen if things change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant