Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the instructions #22

Closed
ja-kub opened this issue Jun 21, 2020 · 3 comments
Closed

Please update the instructions #22

ja-kub opened this issue Jun 21, 2020 · 3 comments

Comments

@ja-kub
Copy link

ja-kub commented Jun 21, 2020

Hey,

First of all - thanks for nice plugin!
Second - please update the instructions how to use it:

  • In your demo project, you are using three android permissions, which are enabled in Export -> Android -> Permissions: Access Network State, Get Accounts and Internet. It should be mentioned in the instructions
    image
  • As it was figured out by @hlfstr here: Sign-in callbacks don't work #5 (comment)
    the callback for _on_player_is_already_connected() requires 2 parameters. So the following will work:
func _on_player_is_already_connected(status : bool, id : String) -> void:
	print("hello from _on_player_is_already_connected\nStatus: %s | ID: %s" % [status,id])
  • First argument in function
    play_games_services.show_saved_games("SNAPSHOT_NAME", allow_add_button, allow_delete_button, max_saved_games_snapshots)
    is not the SNAPSHOT_NAME, but is the title of UI screen with saved games, so for example it could be "See My Saves"
  • To avoid errors with authentication, you should advise users to firstly go through all of this page: https://developers.google.com/games/services/console/enabling
@cgisca
Copy link
Owner

cgisca commented Jul 24, 2020

Hi @ja-kub , thanks for the feedback. I have updated the plugin to use the new Android plugin system for Godot 3.2.2+, also I've updated Readme.md file. Please check it out, and tell me if you find it easy to follow. I followed the new instructions from readme file and found out it pretty straightforward. Thank you!

@ja-kub
Copy link
Author

ja-kub commented Jul 24, 2020

I see that none of these 4 updates were done.

@cgisca
Copy link
Owner

cgisca commented Jul 24, 2020

There is a quick description regarding your points:

  1. You don't need those permissions. All those permissions were added accidentally.
  2. I removed this method. It is not used in the new plugin. If you need it I can add it back but create it synchronous .
  3. I am going to update it now.
  4. Actually it is present in the actual Readme.md. Please check again. Right after Getting started.

@cgisca cgisca closed this as completed Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants