-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with turntable.fm private rooms #22
Comments
Does it switch you to https when you enter a private room? |
yup, that was it. I just went back to http and all is well. Why does https break stuff? |
Chrome requires you to specify http or https when defining which sites it should inject the content scripts. Right now, turntable is only being loaded in http because I never came across a time when turntable bumped me to https. I guess that has since changed. It's a pretty easy fix, I just need to add "https://*.turntable.fm" to the list of supported sites. Thanks for the info! |
If you are interested in seeing the line of code where the fix should be applied, it's here https://github.com/cgravolet/scroblr/blob/master/extension/manifest.json#L31 |
No problem, glad to help! Thanks for the awesome extension. |
I'm currently in a turntable.fm room with some friends and the creator set it up such that you require the link in order to get into the room. The extension scrobbles fine from all other rooms, but seems to be unable to figure out that I'm playing any music as soon as I enter a non-public room.
The text was updated successfully, but these errors were encountered: