Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with turntable.fm private rooms #22

Closed
jvoll opened this issue Jan 4, 2013 · 5 comments
Closed

Doesn't work with turntable.fm private rooms #22

jvoll opened this issue Jan 4, 2013 · 5 comments

Comments

@jvoll
Copy link

jvoll commented Jan 4, 2013

I'm currently in a turntable.fm room with some friends and the creator set it up such that you require the link in order to get into the room. The extension scrobbles fine from all other rooms, but seems to be unable to figure out that I'm playing any music as soon as I enter a non-public room.

@cgravolet
Copy link
Owner

Does it switch you to https when you enter a private room?

@jvoll
Copy link
Author

jvoll commented Jan 4, 2013

yup, that was it. I just went back to http and all is well. Why does https break stuff?

@cgravolet
Copy link
Owner

Chrome requires you to specify http or https when defining which sites it should inject the content scripts. Right now, turntable is only being loaded in http because I never came across a time when turntable bumped me to https. I guess that has since changed. It's a pretty easy fix, I just need to add "https://*.turntable.fm" to the list of supported sites. Thanks for the info!

@cgravolet
Copy link
Owner

If you are interested in seeing the line of code where the fix should be applied, it's here https://github.com/cgravolet/scroblr/blob/master/extension/manifest.json#L31

@jvoll
Copy link
Author

jvoll commented Jan 4, 2013

No problem, glad to help! Thanks for the awesome extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants