Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding docstrings to exported functions #8

Closed
peanutfun opened this issue Feb 11, 2022 · 2 comments
Closed

Consider adding docstrings to exported functions #8

peanutfun opened this issue Feb 11, 2022 · 2 comments

Comments

@peanutfun
Copy link
Contributor

The public API of the DataAssimilationBenchmarks.jl module is currently documented in the README.md. This clutters the document and does not adhere to a standardized documentation formatting.

Julia enables object documentation via docstrings, and advertises a standard to write such documentations. This has the advantage that the documentation is part of the actual source code, and that a formatted documentation can always be generated from the source code with Documenter.jl.

Please consider removing the API documentation from the README.md, and adding appropriate docstrings to the functions of the module that are part of the public API. I think this would work well together with my suggestion in #7, thus making the README.md a more "high-level" overview of the package.

openjournals/joss-reviews#4129

@cgrudz
Copy link
Owner

cgrudz commented Sep 7, 2022

Many thanks, this has been completed adopted in the new documentation pages:
https://cgrudz.github.io/DataAssimilationBenchmarks.jl/dev/

@cgrudz cgrudz closed this as completed Sep 7, 2022
@peanutfun
Copy link
Contributor Author

The documentation really has improved considerably. Thanks a lot for all the effort! ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants