Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme can't work #3

Closed
Strnadj opened this issue Sep 11, 2015 · 1 comment
Closed

Readme can't work #3

Strnadj opened this issue Sep 11, 2015 · 1 comment

Comments

@Strnadj
Copy link

Strnadj commented Sep 11, 2015

Method process_event is in parent class without attributes. Always we can override method perform_handler, but it's useless, because if we do this, we are able only to use event perform... Last thing, if we override process_event, we have to write into body shutdown and exception handler. It will be nice to have in default switch clause perform_handler call instead of throwing an exception.

I am able to provide PR with previously mentioned behaviour.

@chadrem
Copy link
Owner

chadrem commented Sep 11, 2015

@Strnadj I've made some changes based on your feedback:

  • README The Workers class advanced example should now work.
  • You can now add custom events by overriding event_handler(event) and calling super(event) if you want the default handlers to work.
  • Any event handler can now stop the event loop by setting @run = false

I believe these changes address all of your feedback. If not, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants