Update Pytorch package to use Pytorch 2.0.1 #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
changed the title
This was referenced Aug 25, 2023
RunDevelopment
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2139 and will fix #2138
I tested upscaling, face upscaling, and converting to onnx. Everything seems to work fine (i wouldn't really expect anything to break tbh).
This is required for #2092 to pass. However, since on python 3.9 Pytorch 2.0 is slower, we should update to 3.11 before we release this. But i don't think we should delay merging it, as the 3.11 migration will be the next thing i work on.