Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.11 for integrated Python #2144

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Use Python 3.11 for integrated Python #2144

merged 6 commits into from
Aug 28, 2023

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Aug 26, 2023

It's a bit hardcodey, but it works. Basically, I just check the version of the existing integrated python during setup, and if it's a version between 3.9 and 3.10 we get rid of it and do everything else like normal.

Everything seems to just work on 3.11 (except pytorch obviously, but that's been resolved by #2143).

src/main/python/integratedPython.ts Outdated Show resolved Hide resolved
src/main/python/integratedPython.ts Outdated Show resolved Hide resolved
@joeyballentine joeyballentine merged commit 72f5f33 into main Aug 28, 2023
4 checks passed
@joeyballentine joeyballentine deleted the python-3.11 branch August 28, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants