Update for Chai v4.0 #131
Merged
Update for Chai v4.0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meeber think it is possible to get this to work for both chai 3.5 and chai 4? It'd be great to get it merged ahead of time. I suppose we could just check for |
|
@keithamus I've updated this PR for the Chai 4.0 release. Although Chai v4.0 is now a dependency for the test suite (due to changes in failed assertion message text, as well as the replacement of |
keithamus
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chai v4.0 causes some tests to fail due to the change of
deep.propertytonested.property, and also because a couple of assertion error messages changed slightly. This PR fixes the broken tests.DO NOT MERGE YET. This PR will be updated once Chai v4.0 is officially released.