Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0 #244

Merged
merged 1 commit into from
Apr 18, 2019
Merged

4.3.0 #244

merged 1 commit into from
Apr 18, 2019

Conversation

austince
Copy link
Contributor

Chore commit to release 4.3.0

Features:

@austince austince requested a review from keithamus April 17, 2019 19:43
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ❗️

@austince austince merged commit 799f668 into master Apr 18, 2019
@austince
Copy link
Contributor Author

austince commented Apr 18, 2019

🎈 do you want me to write up the release notes + tag? Also, what do you think about incorporating something like semantic release to lift some of this burden? Is that something that would have to be done in coordination with more of the chai org?

@austince austince deleted the 4.3.0 branch April 18, 2019 16:07
@austince
Copy link
Contributor Author

Hey @keithamus, just looping back in if you have some time.

@keithamus
Copy link
Member

We should enable semantic release, for sure! I don't have much time right now sadly, so I wont be able to spend any time on doing this, but I'm happy to glance over some PRs if you plan to make any ;)

@keithamus
Copy link
Member

I've added release notes (https://github.com/chaijs/chai-http/releases/tag/4.3.0). The Travis build should deploy a new version when it passes: https://travis-ci.org/chaijs/chai-http/builds/524975518?utm_source=github_status&utm_medium=notification

@austince
Copy link
Contributor Author

Awesome, thank you! I'll see if I can squeeze in a PR sometime soon 🙂

@mikemfleming
Copy link

I'm happy to help out if there are any other issues y'all would like a contributor on. Is the help wanted label still viable? looks like it's got some old issues.

@keithamus
Copy link
Member

@mikemfleming we're always happy to have contributors to anything in the chai ecosystem 😄. My latest efforts have been in refactoring our inspection engine (chaijs/loupe#14) - it would be great to get some more tests written up for more complex use-cases (see chaijs/loupe#13 (comment)). Otherwise you could have a look through any issue on chai-http (https://github.com/chaijs/chai-http/issues) and help triage them 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants