Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Set Node-Version to >=v16.20 #309

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Conversation

Trickfilm400
Copy link
Contributor

@Trickfilm400 Trickfilm400 commented Jun 16, 2023

Changes

  • Updated (dev-)dependencies
    • is-ip cannot be updated to the latest version due to ESModule incompatibility, but there are also no important changes
    • updated to new mocha configuration file
  • changed one test result because return value changed
    • I'm not sure if this is an upstream change, but it seems so
  • Updated node version in the GitHub actions CI
  • removed dox dependency, as it seems unused
  • Set required nodejs engine version to >=16.20.0, the latest v16 LTS release

Notes

  • Browser Tests are still failing, but they did before all of the updates, so the updates should be unrelated to this issue
  • Should be deprecate the old npm package versions because of the vulnerabilities these versions had?

Based on / Follow Up PR: #306 (comment)

@keithamus keithamus merged commit 4cb31ee into chaijs:main Jun 19, 2023
4 checks passed
@keithamus
Copy link
Member

This is v5.0.0-alpha1. I'd like to get this using ESM before releasing 5 proper, inline with Chai 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants