-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should.approximately support #525
Comments
To underline the inconvenience, in my case (PhantomJS + Mocha + Chai + chai-jquery) going back to original ShouldJS instead of Chai is not an option because the benefits from chai-jquery. |
Hey @axelpale thanks for the issue! We have
If you'd like, I'll happily accept a PR which aliases |
The alias is added in 7fe23e9. This can be closed now. |
👍 |
Oh, nice! Thank you guys. |
I propose ShouldJS's
approximately(value, delta, [description])
assertion should be a part of the core API of Chai. One could use.within(above, below)
to do the job but writing the both limits easily causes code similar to:versus drier:
Furthermore because Chai claims to have Should interface, having all ShouldJS's methods is expected. Therefore to have a separate Chai plugin does not feel practical.
The text was updated successfully, but these errors were encountered: