Release chai@4.3.0 #1266
Closed
Release chai@4.3.0 #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 94.61% 95.48% +0.87%
==========================================
Files 33 33
Lines 1708 2082 +374
Branches 416 583 +167
==========================================
+ Hits 1616 1988 +372
- Misses 92 94 +2
Continue to review full report at Codecov.
|
keithamus
approved these changes
Jun 30, 2019
Closed
|
We're getting test failures on this branch. I won't have time to look at them any time soon, but if one of the other maintainers could, then I can cut a release. |
Closed
|
I'm taking a look at this after my Holidays. I'm back next week, so should be good to go by the weekend. |
|
Is this still happening? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello everyone 馃槉
This is a release for
4.3.0. It doesn't contain that many changes but I think it's important to release this one ASAP so that we can get this feature out.#1257 is important for
jestto be able to show better diffs for people usingchaias their assertion library.As per instructions in
CONTRIBUTING.mda draft release is available at https://github.com/chaijs/chai/releases/tag/untagged-86c01ce248840cb410d6 and will be published once we get this version out. It's been a while since I've last released achaiversion so please let me know if I missed anything.The next step is to get this in and publish the release so that the package can be published to NPM, correct?
I've seen this post though and it seems like we might have to manually publish.
PS: Travis seems to be failing because SauceLabs is under maintenance for free users.