Allow deepEqual fonction to be configured globally #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forty
force-pushed
the
forty/global-custom-comparator
branch
from
79ab6ed
to
cf3dd4a
Compare
|
Can I/Should I do the same MR on the 4.x branch? I think it would be useful for users (like me 😬 ) which are going to be stuck on this release because of the CommonJS drop |
Yeah that could be good if you'd like it in the 4.x branch. I'm not sure how much support we can give to the 4.x branch once we release 5.x but we can at least merge PRs and publish the package. |
|
Awesome, thanks for the review & merge! I created the same MR for 4.x.x then #1553 (same diff as far I can can tell, except chai.js) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative MR to allow configuring the deepEqual function globally, as discussed #1520
I have done things using a "flag", planning for the possibility of customizing the deepEqual function on a per assertion basis (but this is not implemented in this MR).
Please let me know what you think.