Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type detect #1631

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Update type detect #1631

merged 2 commits into from
Jul 25, 2024

Conversation

koddsson
Copy link
Member

@koddsson koddsson requested a review from a team as a code owner July 25, 2024 10:58
@koddsson koddsson enabled auto-merge (squash) July 25, 2024 10:58
@koddsson
Copy link
Member Author

Maybe CI doesn't run because it's not configured for the 4.x.x branch?? Happy to look at it or you can take my word for the tests running green on my machine 😄

 ~/src/koddsson/chai/ [update-type-detect] npm t

> chai@4.4.0 test
> make test

==> [Test :: Node.js]


  .................................................................................................................
  .................................................................................................................
  .................................................................................................................
  .................................................................................................................
  ..............

  466 passing (165ms)

==> [Browser :: build]
==> [Test :: Karma (chrome)]
25 07 2024 13:04:12.011:INFO [karma-server]: Karma v6.4.2 server started at http://localhost:9876/
25 07 2024 13:04:12.012:INFO [launcher]: Launching browsers HeadlessChrome with concurrency unlimited
25 07 2024 13:04:12.014:INFO [launcher]: Starting browser ChromeHeadless
25 07 2024 13:04:12.281:INFO [Chrome Headless 126.0.6478.183 (Mac OS 10.15.7)]: Connected on socket xf8xADDRht1RqKODAAAB with id 47621104
Chrome Headless 126.0.6478.183 (Mac OS 10.15.7): Executed 464 of 464 SUCCESS (0.107 secs / 0.089 secs)
TOTAL: 464 SUCCESS

@koddsson koddsson merged commit 1a36d35 into 4.x.x Jul 25, 2024
@koddsson koddsson deleted the update-type-detect branch July 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koddsson @keithamus