Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd .length(value) deprecation warning to documentation #429
Conversation
valscion
reviewed
Apr 16, 2015
| @@ -1847,16 +1847,59 @@ module.exports = function (chai, _) { | ||
| Assertion.addMethod('haveOwnProperty', assertOwnProperty); | ||
| /** | ||
| * ### .length(value) | ||
| * ### .ownPropertyDescriptor(name[, descriptor[, message]]) |
This comment has been minimized.
This comment has been minimized.
valscion
Apr 16, 2015
Contributor
The built source seems to create a funky diff — I haven't touched the ownPropertyDescriptor matcher at all.
This comment has been minimized.
This comment has been minimized.
|
Sorry @valscion - I should have mentioned you don't need to update chai.js - it will be updated as part of the release cycle. Could you pretty please remove it from the commit? |
keithamus
reviewed
Apr 16, 2015
| @@ -956,8 +950,25 @@ module.exports = function (chai, _) { | ||
| * expect('foo').to.have.length.within(2,4); | ||
| * expect([ 1, 2, 3 ]).to.have.length.within(2,4); | ||
| * | ||
| * *Deprecatin notice:* Using `length` as an assertion will be deprecated | ||
| * in version 2.2.1 and removed in 2.3. Code using the old style of |
This comment has been minimized.
This comment has been minimized.
keithamus
Apr 16, 2015
Member
Next release will be 2.3.0, and we'll have to remove it in 3.0.0 to keep semver. So could you please change this message to:
* *Deprecation notice:* Using `length` as an assertion will be deprecated
* in version 2.3.0 and removed in 3.0.0. Code using the old style of(Also you had a typo in Depricatin(sic))
valscion
force-pushed the
valscion:document-deprecation-plan-of-length
branch
from
21cf438
to
2330d93
Apr 17, 2015
This comment has been minimized.
This comment has been minimized.
Ah, it wasn't so clear based on As for the deprecation notice text, I changed them to what you suggested. |
This comment has been minimized.
This comment has been minimized.
|
Hey @keithamus, is everything OK now? |
This comment has been minimized.
This comment has been minimized.
|
Sorry @valscion this one slipped by me. Version is a number out now, but I'll fix that as it's my bad. All looks good, thanks for your hard work |
added a commit
that referenced
this pull request
May 10, 2015
valscion commentedApr 16, 2015
Fixes #427