Fix wrong order of expected and actual values for members matcher

[eeroan]

This caused i.e. WebStorm's diff view to show actual value as expected and vice versa.

[keithamus]

@eeroan thanks for the PR, but it seems like this is failing the test suite - you havent modified the tests, which'll need to be done before this PR can be merged. Are you happy to do that?

[eeroan]

Sure. Maybe tomorrow.

On 1.9.2015, at 13.51, Keith Cirkel notifications@github.com wrote:

@eeroan https://github.com/eeroan thanks for the PR, but it seems like this is failing the test suite - you havent modified the tests, which'll need to be done before this PR can be merged. Are you happy to do that?

—
Reply to this email directly or view it on GitHub #511 (comment).

—
Eero Anttila <eea@iki.fi mailto:eea@iki.fi>
+358 50 359 0079

[keithamus]

@eeroan any chance you could update the tests for this PR? I'd be keen to merge it 😄

[eeroan]

I tried to fix the tests but it turned out to be a huge change in tests/production code so I gave up :(

Perhaps it’s easier for you, since you are more familiar with the codebase.

On 2.10.2015, at 12.48, Keith Cirkel notifications@github.com wrote:

@eeroan https://github.com/eeroan any chance you could update the tests for this PR? I'd be keen to merge it

—
Reply to this email directly or view it on GitHub #511 (comment).

[meeber]

Hi! Just change the four #{act} to #{exp} in the lines linked below and you're golden. The error message was previously correct for the old transposed actual/expected, so you'd just be making it correct for the new fixed actual/expected. No additional changes to any other code or tests required :)

chai/lib/chai/core/assertions.js

Lines 1588 to 1589 in 4f72846

	, 'expected #{this} to be a superset of #{act}'
	, 'expected #{this} to not be a superset of #{act}'

chai/lib/chai/core/assertions.js

Lines 1597 to 1598 in 4f72846

	, 'expected #{this} to have the same members as #{act}'
	, 'expected #{this} to not have the same members as #{act}'

(Or lemme know if you want me to PR it)

[eeroan]

Tests are now fixed

[keithamus]

This file should be excluded from the diff. See the notes around pull requests here: https://github.com/chaijs/chai/blob/master/CONTRIBUTING.md#pull-requests

Namely:

npm test
# when finished running tests...
git checkout chai.js

[meeber]

Fixed via #702