Apply the same logic in .throws() to .doesNotThrow() so it matche…
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s error messages - `.doesNotThrow()` is currently not matching the error message, although its description says so - Changed `.Throw` to `.throw` so its consistent with `.throws()` - Added test - See chaijs#634 for examples
|
Just saw #551, this issue might be fixed there, feel free to close this if that's the case. |
|
@lucasfcosta again - how does #683 affect this? |
|
@keithamus Hmmm, this one is interesting, I think we have a problem with the assert interface. |
|
@lucasfcosta I've lost track where we stand on this. Do we still have work to do with the error stuff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it matches error messages
.doesNotThrow()is currently not matching the error message, although its description says so.Throwto.throwso its consistent with.throws()doesNotThrow()doesn't match error messages #634 for examples