Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion subject (obj) changes when using ownProperty assertion #641

Merged
merged 2 commits into from Mar 15, 2016

Conversation

lucasfcosta
Copy link
Member

This aims to solve #281.
I've finished the changes to the assertion implementation but I also plan to add this assertion to the assert interface (and add tests for that).

  • ownProperty JSDoc Comments (Examples included)
  • ownProperty accepts value
  • ownProperty changes target (enables chaining)
  • ownProperty tests on should interface
  • ownProperty tests on expect interface
  • Implementation on the assert interface
  • ownProperty tests on assert interface

@keithamus
Copy link
Member

Everything about this looks great so far. Look forwarding to seeing a complete PR @lucasfcosta 😄

@lucasfcosta
Copy link
Member Author

Well, I think it's done.
Thanks for taking a look at it @keithamus, I hope you like this 😄

@keithamus
Copy link
Member

Stellar work as always @lucasfcosta!

keithamus added a commit that referenced this pull request Mar 15, 2016
[WIP] Assertion subject (obj) changes when using ownProperty assertion
@keithamus keithamus merged commit 6b11cc5 into chaijs:4.x.x Mar 15, 2016
@lucasfcosta
Copy link
Member Author

Thanks!
Let's keep pushing Chai forward 😄

@lucasfcosta lucasfcosta changed the title [WIP] Assertion subject (obj) changes when using ownProperty assertion Assertion subject (obj) changes when using ownProperty assertion Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants