Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chai@4.1.0 #998

Merged
merged 1 commit into from Jul 11, 2017
Merged

chai@4.1.0 #998

merged 1 commit into from Jul 11, 2017

Conversation

v1adko
Copy link
Contributor

@v1adko v1adko commented Jun 24, 2017

@keithamus Ran make release-minor, hopefully I've guessed correctly. Decided it's not just a patch because there was a new feature/support added in #994, and not only date fixes, if you disagree I'll update this PR quickly to patch.

Copy link
Contributor

@meeber meeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keithamus
Copy link
Member

Great work @v1adko!

The last thing we need to create this release is some release notes!

They should follow this format:

New Features

Bug Fixes

Documentation

Here are all of the changes since 4.0.2, so we need to document #988, #990, #992, #993, and #994.

Anyone who would like to write the release notes, please feel free to add as a comment below!

@v1adko
Copy link
Contributor Author

v1adko commented Jun 26, 2017

Here's a pre-filled template (v.0.0.1) :)
This comment should be editable by the maintainers, so feel free.
I'm not yet confident enough to write release notes, so let's crowdsource this.

As for the dates support I've decided that it's a bugfix (returned support of the broken feature), but we can discuss this.

New Features

Bug Fixes

My guess is that there were no dedicated doc updates? Or does it need a separate PR in the docs
repo
?

@v1adko
Copy link
Contributor Author

v1adko commented Jul 3, 2017

@keithamus, @meeber, @vieiralucas Any volunteers to help?)

@cletusw
Copy link

cletusw commented Jul 7, 2017

Friendly ping.

I understand the desire to have other contributors help with releases, but at some point, maintainers might need to take responsibility for getting things released. This PR includes a fix (#990) for what could be argued to be an accidental breaking change. The fix was merged over two weeks ago and is still waiting for a release.

@keithamus Do you think you could help finish out what remains to be done to get this released? Thanks!

@meeber
Copy link
Contributor

meeber commented Jul 8, 2017

Been on vacay since the 23rd. Should get back home tomorrow night. Will try to carve out some time on Sunday to look at this if no one is able to before then.

@meeber
Copy link
Contributor

meeber commented Jul 10, 2017

I made a couple small changes in-place on @v1adko's release notes (most notably removing reference to the refactor commit since it was a purely internal code update). We currently have a failing build due to an IE11 issue, so I'd like #1005 to get merged (and verify build is passing) before we release this. That commit doesn't need to be mentioned in the release notes. This should be releasable tomorrow evening. I'll try to set aside some time after work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants