Try to fix windows build

[flaambe]

Tests to fix:

• Acceptance
• Class
• Maps
• Promises
• Sets
• Typed arrays
• Weaksets

[keithamus]

Looks like destructuring is also failing. Perhaps bringing in @babel/preset-env and setting it to IE11 would get allow for all the needed features to be transpiled.

[flaambe]

Object doesn't support property or method 'entries' I think we need core-js

3 fails left to fix

I think the last problem is Object.getOwnPropertySymbols not properly polyfilled

Symbol('foo') turns to Symbol{}

@keithamus

[flaambe]

What is better to add a babel plugin to transform

 Object.entries, Object.assign

or write polyfill manually?

[keithamus]

We seem to only use Object.entries and Object.assign in the 1 table in ./test/object.js. I'd suggest we-writing them completely; so L3-6 of ./test/objects.js should become:

const table = {
  objects: loupe,
  'objects (Object.create(null))': (obj, ...rest) => {
    const newObj = Object.create(null)
    for(const k in obj) {
      Object.defineProperty(newObj, k, Object.getOwnPropertyDescriptor(obj, k)
    }
    return loupe(newObj, ...rest)
  }
}
for (const suite of table) {
  const inspect = table[suite]

[flaambe]

TypeError: table[Symbol.iterator] is not a function @keithamus

If i changle like this, than it works

for (const suite of Array.from(table)) {
  const inspect = table[suite]

Or just

for (const suite in table) {
  const inspect = table[suite]

Sorry, I accidentally deleted your commit, can you push it again?

[keithamus]

Yeah sorry I meant for(const suite in.... Sorry I can't give this my full attention.

I've pushed the changes. 🤞 this build passes! Thanks for all your awesome efforts here @flaambe!

[flaambe]

I think it will be difficult to fix everything without polyfills (Set, WeakSet, Promises and etc). What do you think about it? @keithamus

[keithamus]

Sadly our guideline is to support IE11 until EOL: https://github.com/chaijs/guidelines/blob/master/support-cycle.md#internet-explorer

We can load polyfills in the local test harness, but the library must run without them, as we cannot mutate the global environment within user's test harnesses. They might want to bring in alternative polyfills.

[flaambe]

Ok, thanks for explaining

[keithamus]

@flaambe I just pushed up a new commit. If you want to continue force pushing to this branch it might be worth using --force-with-lease - if you're not already. It prevents you from force pushing a branch to a stale origin.

[flaambe]

@keithamus Ok

I think the problem is that IE map,sets do not accept arrays

[flaambe]

It's strange, the documentation says that the name property of typed arrays is supported starting from IE 10

[flaambe]

Maybe just skip tests where the IE doesn't support Promises, Weakset and iterable parameter for Map, Set? @keithamus

[keithamus]

Tests must consistently pass for IE11 as they do in other browsers. If IE11 has different results when people come to depend on them that will not be ideal. We should instead polyfill the test environment to ensure these pieces are there.

[keithamus]

Looks like the only thing failing now is Symbol because of Corejs. It polyfills Symbol.prototype.description - so we could write code to detect for that and use it over toString().

--- lib/symbol.js
+++ lib/symbol.js
@@ -1,3 +1,6 @@
 export default function inspectSymbol(value) {
+  if ('description' in Symbol.prototype) {
+    return `Symbol(${value.description})`
+  }
   return value.toString()
 }

[flaambe]

If you have time, see what can be done. I'm busy now, I’ll be free in 2-3 hours.

[flaambe]

As I said above @keithamus

Symbol('foo') turns to Symbol{}

[keithamus]

Yeah, I see that. Not sure where that is coming from.

[flaambe]

I think I should rebase, since there are a lot of unnecessary commits, but first we need to decide what to do with Symbol

[flaambe]

I think this is a problem, because of the bundle Rollup + Babel. Maybe just skip these 3 tests for now, as I don’t see a solution? @keithamus

[keithamus]

I've got a good feeling about this one @flaambe

[keithamus]

🎉 congratulations @flaambe! You did it! Thank you so much for all your work on this 👍

[flaambe]

Thank you for all the advice @keithamus