Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust testing tolerance of F.connectionist_temporal_classification #5928

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

takagi
Copy link
Member

@takagi takagi commented Dec 25, 2018

This PR adjusts testing tolerance of F.connectionist_temporal_classification with float16 data.

@takagi takagi added the cat:test Test or CI related. label Dec 25, 2018
@hvy
Copy link
Member

hvy commented Dec 27, 2018

jenkins, test this please.

@hvy hvy self-assigned this Dec 27, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0a452a8, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@hvy
Copy link
Member

hvy commented Dec 27, 2018

This tolerance seems extremely relaxed but is this the case for many other float16 operations?

@hvy
Copy link
Member

hvy commented Dec 27, 2018

I see we have other functions with similar order. LGTM!

@hvy hvy merged commit 284e3c1 into chainer:master Dec 27, 2018
@hvy hvy added this to the v6.0.0b2 milestone Dec 27, 2018
@takagi takagi added the to-be-backported Pull request that should be backported. label Jan 17, 2019
@chainer-ci
Copy link
Member

@hvy This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

hvy added a commit to hvy/chainer that referenced this pull request Jan 21, 2019
Adjust testing tolerance of F.connectionist_temporal_classification
takagi pushed a commit to takagi/chainer that referenced this pull request Jan 21, 2019
Adjust testing tolerance of F.connectionist_temporal_classification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants