Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post macro comment for consistency #6014

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

hvy
Copy link
Member

@hvy hvy commented Jan 17, 2019

Style fixes for consistency.

@hvy hvy added ChainerX Related to ChainerX. cat:code-fix Code refactoring that does not change the behavior. labels Jan 17, 2019
@niboshi
Copy link
Member

niboshi commented Jan 17, 2019

jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2fc81bd, target branch master) succeeded!

Co-Authored-By: hvy <hiroyuki.vincent.yamazaki@gmail.com>
@niboshi
Copy link
Member

niboshi commented Jan 17, 2019

Jenkins, test this please

@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Jan 17, 2019
@niboshi niboshi removed the ChainerX Related to ChainerX. label Jan 17, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit baf3a8f, target branch master) succeeded!

@niboshi
Copy link
Member

niboshi commented Jan 17, 2019

LGTM

@niboshi niboshi merged commit 97a3514 into chainer:master Jan 17, 2019
@hvy hvy deleted the consistency-post-macro-comment branch January 17, 2019 08:54
@hvy hvy added this to the v6.0.0b2 milestone Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that does not change the behavior. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants