Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestContrastive #7747

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Fix flaky TestContrastive #7747

merged 1 commit into from
Jul 12, 2019

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jul 10, 2019 •
edited
Loading

Fix #7704.

chainer/chainer/functions/loss/contrastive.py

Line 83 in 23941e8

gx0 += alpha * (1 - y) * mdist * -(diff / dist)

Hard to calculate numerical gradient correctly when x1 - x2 includes a value around zero.

@asi1024 asi1024 added the cat:test Test or CI related. label Jul 10, 2019
@asi1024 asi1024 changed the title Fixed flaky TestContrastive Fix flaky TestContrastive Jul 10, 2019
@niboshi niboshi self-assigned this Jul 12, 2019
@niboshi niboshi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Jul 12, 2019
@asi1024
Copy link
Member Author

asi1024 commented Jul 12, 2019

@niboshi Updated comment. Could you take a look?

@niboshi niboshi removed the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Jul 12, 2019
@niboshi
Copy link
Member

niboshi commented Jul 12, 2019

Jenkins, test this please

@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Jul 12, 2019
@niboshi niboshi added this to the v7.0.0b2 milestone Jul 12, 2019
@niboshi niboshi added the to-be-backported Pull request that should be backported. label Jul 12, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 6ba6fa8, target branch master) succeeded!

@mergify mergify bot merged commit 314548c into chainer:master Jul 12, 2019
@asi1024 asi1024 deleted the flaky-contrastive2 branch July 12, 2019 09:49
@chainer-ci
Copy link
Member

@mergify[bot] This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

niboshi pushed a commit to niboshi/chainer that referenced this pull request Jul 16, 2019
@mergify @niboshi
Merge pull request chainer#7747 from asi1024/flaky-contrastive2
28477d8 
Fix flaky `TestContrastive`
@niboshi niboshi mentioned this pull request Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niboshi niboshi niboshi approved these changes

Assignees

@niboshi niboshi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0b2
Development

Successfully merging this pull request may close these issues.

Flaky test: chainer_tests/functions_tests/loss_tests/test_contrastive.py::TestContrastive
3 participants
@asi1024 @niboshi @chainer-ci