Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax tolerances in gradient_check test #7989

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 21, 2019

Fixes #7973

Confirmed by 100000 repeats

x1 = numpy.arange(size).astype('float32')
x2 = numpy.arange(size).astype('float32')
g1 = numpy.ones(size, dtype='float32')
g2 = numpy.ones(size, dtype='float32')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just cosmietic fixes

@niboshi niboshi added cat:test Test or CI related. prio:high High priority. Urgent and needs to be worked on as soon as possible. to-be-backported Pull request that should be backported. labels Aug 21, 2019
@emcastillo emcastillo self-assigned this Aug 21, 2019
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit d86dd8c, target branch master) succeeded!

@emcastillo emcastillo added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Aug 23, 2019
@mergify mergify bot merged commit d4364b0 into chainer:master Aug 23, 2019
emcastillo pushed a commit to emcastillo/chainer that referenced this pull request Aug 23, 2019
…check

Relax tolerances in `gradient_check` test
@niboshi niboshi added this to the v7.0.0b4 milestone Aug 23, 2019
@niboshi niboshi deleted the test-tolerance-gradient-check branch August 23, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. prio:high High priority. Urgent and needs to be worked on as soon as possible. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlakyTest: tests/chainer_tests/test_gradient_check.py
3 participants