-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax tolerances in gradient_check
test
#7989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
commented
Aug 21, 2019
x1 = numpy.arange(size).astype('float32') | ||
x2 = numpy.arange(size).astype('float32') | ||
g1 = numpy.ones(size, dtype='float32') | ||
g2 = numpy.ones(size, dtype='float32') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just cosmietic fixes
niboshi
added
cat:test
Test or CI related.
prio:high
High priority. Urgent and needs to be worked on as soon as possible.
to-be-backported
Pull request that should be backported.
labels
Aug 21, 2019
emcastillo
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins, test this please |
Jenkins CI test (for commit d86dd8c, target branch master) succeeded! |
emcastillo
added
the
st:test-and-merge
State indicating that pull request is approved by a reviewer and can be merged after CI passes.
label
Aug 23, 2019
emcastillo
pushed a commit
to emcastillo/chainer
that referenced
this pull request
Aug 23, 2019
…check Relax tolerances in `gradient_check` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:test
Test or CI related.
prio:high
High priority. Urgent and needs to be worked on as soon as possible.
st:test-and-merge
State indicating that pull request is approved by a reviewer and can be merged after CI passes.
to-be-backported
Pull request that should be backported.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7973
Confirmed by 100000 repeats