Use ChainerX softmax cross entropy implementation in ChainerX examples #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takagi
force-pushed
the
chainerx-example-softmax-cross-entropy
branch
2 times, most recently
from
558594d
to
3166da3
Compare
takagi
force-pushed
the
chainerx-example-softmax-cross-entropy
branch
from
3166da3
to
0523744
Compare
|
#8250 is now merged. |
…oftmax-cross-entropy
|
Now I've merged the master! |
|
Could you fix the style errors? |
|
Fixed! |
hvy
requested changes
Oct 28, 2019
Co-Authored-By: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
Co-Authored-By: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
|
I missed to apply the change that ChainerX SCE now returns the batch-wise result without reduced. PTAL. |
|
Could you merge with the latest master as it should fix the C++ example? |
|
Merged! |
|
LGTM! |
|
Jenkins, test this please. |
hvy
approved these changes
Nov 1, 2019
hvy
added
the
st:test-and-merge
|
Jenkins CI test (for commit 7b3089c, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #8250 .
takagi/chainer@chainerx-softmax-cross-entropy...takagi:chainerx-example-softmax-cross-entropy
This PR fixes ChainerX examples to use ChainerX softmax cross entropy implementations introduced in #8250 .