Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Make ImportWarning just a warning in tests #8308

Closed

Conversation

emcastillo
Copy link
Member

Backport of #8291

Make ImportWarning just a warning in tests
@emcastillo emcastillo added backport Pull request that is backported from a more recent version. cat:test Test or CI related. labels Oct 18, 2019
@emcastillo
Copy link
Member Author

[automatic post] Jenkins, test this please.

@emcastillo
Copy link
Member Author

Backport wasn't clean, please verify 🙂

@toslunar
Copy link
Member

Because #6653 has not been backported to v6, this change to v6 has a different meaning: show ImportWarning which is ignored by default. I am sorry that I was not aware of it.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit ccf5738, target branch v6) succeeded!

@emcastillo
Copy link
Member Author

@toslunar I guess it is safer to close this one then!😄

@toslunar
Copy link
Member

I agree.

@toslunar toslunar closed this Oct 23, 2019
@kmaehashi kmaehashi added this to the Closed issues and PRs milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull request that is backported from a more recent version. cat:test Test or CI related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants