chore: skip localnet specific tests in devnet 🤫 #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-793 Bouncer test that tests shutting down nodes to be re-instated for all networks?
For non-CI and non-local networks we had to disable the bouncer test that shuts down the connection to the external blockchains and then re-establishes connection. This is because networks like Sisyphos use a different, more production ready setup that means this method of shutting down containers can't be used. The question remains whether it's actually useful in these cases. Given we've seen it work in local and CI. The reason we might want to is to see its impact on a multi node network (which if one node's ETH connection goes down, should be none in a 3 node network). Original test ticket: PRO-700 |
Codecov Report
@@ Coverage Diff @@
## main #3919 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 366 366
Lines 56773 56773
Branches 56773 56773
=====================================
- Hits 40540 40522 -18
- Misses 14217 14231 +14
- Partials 2016 2020 +4 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
albert-llimos
approved these changes
Aug 30, 2023
martin-chainflip
approved these changes
Aug 30, 2023
kylezs
approved these changes
Aug 30, 2023
syan095
added a commit
that referenced
this pull request
Sep 4, 2023
* origin/main: Fix: Correct Select Median Implementation (#3934) fix: independent witnessing startup (#3913) 🍒 cherry-pick: changes in release for CI and chainspec (#3933) refactor: Re-arrange Chains traits for better composability (#3912) fix: log error when we try to transfer *more* than we have fetched (#3930) chore: add checks and increase timeout (#3928) Add `bind_redeem_address` to CLI (#3908) 🍒 cherry-pick: add missing prod dockerfiles (#3926) chore: skip localnet specific tests in devnet 🤫 (#3919) fix: broadcast success should be witnessable after a rotation (#3921) # Conflicts: # state-chain/chains/src/eth/api.rs # state-chain/runtime/src/chainflip.rs
syan095
added a commit
that referenced
this pull request
Sep 5, 2023
…on-integration * origin/main: Added CFE setting for logging span lifecycles (#3936) fix: only burn flip if non zero (#3932) Fix: Correct Select Median Implementation (#3934) fix: independent witnessing startup (#3913) 🍒 cherry-pick: changes in release for CI and chainspec (#3933) refactor: Re-arrange Chains traits for better composability (#3912) fix: log error when we try to transfer *more* than we have fetched (#3930) chore: add checks and increase timeout (#3928) Add `bind_redeem_address` to CLI (#3908) 🍒 cherry-pick: add missing prod dockerfiles (#3926) chore: skip localnet specific tests in devnet 🤫 (#3919) fix: broadcast success should be witnessable after a rotation (#3921) # Conflicts: # state-chain/cf-integration-tests/src/network.rs
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* chore: skip localnet specific tests in devnet 🤫 * chore: flip logic * fix: condition * fix: simplify conditional
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* chore: skip localnet specific tests in devnet 🤫 * chore: flip logic * fix: condition * fix: simplify conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.