Added CFE setting for logging span lifecycles #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-764 Make all tracing span levels TRACE
We currently have a lot of noise in the logs from tracing spans. This is because many spans are declared as INFO- or DEBUG-level spans. I would suggest we make all spans TRACE-level so that we have the option to log them selectively, but they are disabled by default. |
j4m1ef0rd
changed the title
j4m1ef0rd
force-pushed
the
feat/log_span_lifecycle_setting
branch
from
02eee1f
to
99d9c4c
Compare
Codecov Report
@@ Coverage Diff @@
## main #3936 +/- ##
=====================================
- Coverage 73% 72% -0%
=====================================
Files 367 367
Lines 56037 56047 +10
Branches 56037 56047 +10
=====================================
- Hits 40631 40629 -2
- Misses 13345 13351 +6
- Partials 2061 2067 +6
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kylezs
approved these changes
Sep 4, 2023
syan095
added a commit
that referenced
this pull request
Sep 5, 2023
…on-integration * origin/main: Added CFE setting for logging span lifecycles (#3936) fix: only burn flip if non zero (#3932) Fix: Correct Select Median Implementation (#3934) fix: independent witnessing startup (#3913) 🍒 cherry-pick: changes in release for CI and chainspec (#3933) refactor: Re-arrange Chains traits for better composability (#3912) fix: log error when we try to transfer *more* than we have fetched (#3930) chore: add checks and increase timeout (#3928) Add `bind_redeem_address` to CLI (#3908) 🍒 cherry-pick: add missing prod dockerfiles (#3926) chore: skip localnet specific tests in devnet 🤫 (#3919) fix: broadcast success should be witnessable after a rotation (#3921) # Conflicts: # state-chain/cf-integration-tests/src/network.rs
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
feat: added span setting and cmd line arg
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
feat: added span setting and cmd line arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-764
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
We were not able to find an easy solution for changing the span lifecycle logs during runtime (See Linier issue for details), so the best we can do is have it as a startup setting.
I added
--logging.span_lifecyclecommand line arg that isfalseby default. This will stop all of the "enter/exit" log messages unless you restart your CFE with the setting enabled: