fix: only burn flip if non zero #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janislav
reviewed
Aug 31, 2023
| ), | ||
| None, | ||
| ); | ||
| } | ||
| T::Issuance::burn(flip_to_burn.into()); |
There was a problem hiding this comment.
I think this has to move into the if clause 🤔
There was a problem hiding this comment.
Oops good catch.
Codecov Report
@@ Coverage Diff @@
## main #3932 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 366 366
Lines 56798 56802 +4
Branches 56798 56802 +4
=====================================
+ Hits 40545 40551 +6
+ Misses 14240 14237 -3
- Partials 2013 2014 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ramizhasan111
approved these changes
Sep 1, 2023
ramizhasan111
approved these changes
Sep 1, 2023
syan095
added a commit
that referenced
this pull request
Sep 5, 2023
…on-integration * origin/main: Added CFE setting for logging span lifecycles (#3936) fix: only burn flip if non zero (#3932) Fix: Correct Select Median Implementation (#3934) fix: independent witnessing startup (#3913) 🍒 cherry-pick: changes in release for CI and chainspec (#3933) refactor: Re-arrange Chains traits for better composability (#3912) fix: log error when we try to transfer *more* than we have fetched (#3930) chore: add checks and increase timeout (#3928) Add `bind_redeem_address` to CLI (#3908) 🍒 cherry-pick: add missing prod dockerfiles (#3926) chore: skip localnet specific tests in devnet 🤫 (#3919) fix: broadcast success should be witnessable after a rotation (#3921) # Conflicts: # state-chain/cf-integration-tests/src/network.rs
dandanlen
added a commit
that referenced
this pull request
Sep 6, 2023
dandanlen
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This avoid scheduling an egress of zero for the flip buy-and-burn if the collected fees are zero.