Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick/release-1.0.1 #4259

Merged
merged 30 commits into from
Nov 20, 2023
Merged

Pick/release-1.0.1 #4259

merged 30 commits into from
Nov 20, 2023

Conversation

dandanlen
Copy link
Collaborator

Cherry picks commits from main to create a 1.0.1 release.

All commits from main were included except 22e9288 to avoid a CFE-breaking change.

AlastairHolmes and others added 28 commits November 17, 2023 10:24
@AlastairHolmes @dandanlen
cleanup scc (#4213)
f998caa 
cleanup
@AlastairHolmes @dandanlen
refactor: replace latest_finalized_hash with latest_finalized_header (#…
c9746ba 
…4206)

refactor: latest_finalized_header
@AlastairHolmes @dandanlen
feat: get new block streams from scc after creation (#4217)
5cd566f 
* feat: get new block streams from scc

* fix bad rebase
@albert-llimos @dandanlen
Chore/update eth contracts tag (#4218)
c9c17f4 
* chore: update tag to v1.0.0

* chore: added IVault's transferFallback
@martin-chainflip @dandanlen
Banana mode should use the new uppercase assets (#4215)
0b35c15 
change assets in banana mode to comply with new uppercase assets in LP API
@msgmaxim @dandanlen
feat: prewitnessing uses unfinalised sc stream (#4220)
c9e0a7e
@marcellorigotti @dandanlen
feat: improve Dot Existential Deposit Test (#4195)
32557ff 
* added performAndTrackSwap:
which create and execute a swap tracking all the relative events

* added getSwapRate

* added chain to broadcastId:
we need to track the correct broadcaster, there can be different chain
with the same broadcastId

* add check before executing test

* address comments

* eslint

* added checks to make the test runnable concurrently

* added checks to make it run concurrently

* fix RpcAsset error

* addressed comments
@msgmaxim @dandanlen
chore: localnet asks binary locations before destroying (#4225)
daecff3 
chore: localnet asks binary locations before destroying
@marcellorigotti @dandanlen
Replace () in pendingRedemptions with Pending (#4201)
5ff4545
@syan095 @dandanlen
Improved error display (#4209)
0ec352e 
* Changed a DispatchError::Other() to a pallet error, so it can be displayed
on the front end properly.

* Replaced DispatchError::Other with module error for better display
Improved dry run's debug logging for more clarity

* minor rename
@msgmaxim @dandanlen
feat: dynamic min authority count (#4224)
f2ed148
@kylezs @dandanlen
chore: rename internal adapter to DepositAddresses (#4230)
cc3a667 
* chore: rename internal adapter to DepositAddresses

* chore: comments to use deposit instead of ingress
@dandanlen
feat: user friendly error on asset parse failure (#4229)
e3b5ec2
@syan095 @dandanlen
chore: Renamee AccountRoles::None to Unregistered (#4208)
742dbc9
@kylezs @dandanlen
refactor: use btc rpc client for mempool tracker (#4227)
acffdf1 
refactor: use btc client for mempool tracker
@j4m1ef0rd @dandanlen
chore: CFE tracing, don't log current span twice (#4240)
606b370 
chore: only log span list
@dandanlen
chore: fix naming of session keys (#4242)
85bc12c
@dandanlen
fix: revert restricted balances (#4237)
9342041
@j4m1ef0rd @dandanlen
feat: CLI generate keys outputs peer id (#4241)
2d50d3c
@msgmaxim @dandanlen
fix: add missing spans in multisig logs (#4239)
7e4b06a
@dandanlen
chore: fix cargo features (#4249)
f4975c8
@dandanlen
fix: remove bound addresses on account deletion (#4244)
8252448
@dandanlen
fix: remove existential deposit (#4243)
7296803
@syan095 @dandanlen
feat: Maximum Swap amount (#4238)
cb51b31 
Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com>
@kylezs @dandanlen
fix: egress id race condition (#4235)
1ff78c6
@kylezs @dandanlen
fix: remove unwrap when getting tx receipt (#4231)
1f74359 
* fix: don't unwrap on None tx receipt

* chore: nicer fmt
@msgmaxim @dandanlen
refactor: shared source inside chunked_by adapters (#4232)
0df6b66 
* refactor: shared source inside chunked_by adapters

* chore: address review
@dandanlen
chore: bump versions
0030036
@dandanlen dandanlen requested review from a team as code owners November 17, 2023 17:13
@dandanlen dandanlen requested review from ahasna, tomjohnburton, jerryafr and niklasnatter and removed request for a team November 17, 2023 17:13
@dandanlen dandanlen marked this pull request as draft November 17, 2023 17:18
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited

Codecov Report

Attention: 785 lines in your changes are missing coverage. Please review.

Comparison is base (1a27d50) 71% compared to head (d06d81e) 71%.
Report is 2 commits behind head on release/1.0.

Files Patch % Lines
...d_chain_source/chunked_by_vault/monitored_items.rs 0% 192 Missing ⚠️
engine/src/btc/rpc.rs 0% 153 Missing ⚠️
engine/src/state_chain_observer/client/mod.rs 20% 147 Missing and 6 partials ⚠️
...nked_chain_source/chunked_by_vault/egress_items.rs 0% 43 Missing ⚠️
...chain_source/chunked_by_vault/deposit_addresses.rs 0% 34 Missing ⚠️
...ngine/src/witness/common/chain_source/extension.rs 0% 18 Missing ⚠️
engine/src/witness/dot.rs 0% 17 Missing ⚠️
state-chain/pallets/cf-swapping/src/weights.rs 0% 16 Missing ⚠️
api/lib/src/lib.rs 36% 14 Missing ⚠️
state-chain/runtime-upgrade-utilities/src/lib.rs 0% 14 Missing ⚠️
... and 32 more
Additional details and impacted files 
@@             Coverage Diff              @@
##           release/1.0   #4259    +/-   ##
============================================
  Coverage           71%     71%            
============================================
  Files              383     385     +2     
  Lines            62709   63320   +611     
  Branches         62709   63320   +611     
============================================
+ Hits             44831   45272   +441     
- Misses           15543   15705   +162     
- Partials          2335    2343     +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandanlen and others added 2 commits November 20, 2023 13:52
@dandanlen
fix: protect against double witnessing after safe mode (#4254)
62e456a
@kylezs @dandanlen
fix: runtime upgrade utils and migrations (#4258)
d06d81e 
* fix: use executive pallet to run tuple migrations

chore: remove on_runtime_upgrade calls from pallets

fix: upgrade utils

clippy

* doc: update README

* fix: run try-runtime tests on CI
@dandanlen dandanlen marked this pull request as ready for review November 20, 2023 15:12
@tomjohnburton tomjohnburton merged commit 818e630 into release/1.0 Nov 20, 2023
40 checks passed
@tomjohnburton tomjohnburton deleted the pick/release-1.0.1 branch November 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-chainflip martin-chainflip martin-chainflip approved these changes

@ahasna ahasna Awaiting requested review from ahasna ahasna is a code owner automatically assigned from chainflip-io/platform

@tomjohnburton tomjohnburton Awaiting requested review from tomjohnburton tomjohnburton is a code owner automatically assigned from chainflip-io/platform

@jerryafr jerryafr Awaiting requested review from jerryafr jerryafr is a code owner automatically assigned from chainflip-io/web

@niklasnatter niklasnatter Awaiting requested review from niklasnatter niklasnatter is a code owner automatically assigned from chainflip-io/web

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dandanlen @martin-chainflip @tomjohnburton @AlastairHolmes @albert-llimos @msgmaxim @marcellorigotti @syan095 @kylezs @j4m1ef0rd