fix: protect against double witnessing after safe mode #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
force-pushed
the
fix/double-witness-protection-safe-mode
branch
from
0aa5209
to
f0ea861
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4254 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 384 384
Lines 63571 63618 +47
Branches 63571 63618 +47
=====================================
+ Hits 45482 45522 +40
- Misses 15749 15753 +4
- Partials 2340 2343 +3 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Nov 20, 2023
| call, | ||
| call_hash, | ||
| ); | ||
| if (last_expired_epoch..=current_epoch) |
There was a problem hiding this comment.
I swear we had this check once before 🤔
dandanlen
added a commit
that referenced
this pull request
Nov 20, 2023
tomjohnburton
pushed a commit
that referenced
this pull request
Nov 20, 2023
Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com> Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com> Co-authored-by: Albert Llimos <53186777+albert-llimos@users.noreply.github.com> Co-authored-by: Martin Rieke <121793148+martin-chainflip@users.noreply.github.com> Co-authored-by: Maxim Shishmarev <msgmaxim@gmail.com> Co-authored-by: Marcello <marcello@chainflip.io> Co-authored-by: Roy Yang <roy@chainflip.io> Co-authored-by: kylezs <kyle@chainflip.io> Co-authored-by: Jamie Ford <jamie@chainflip.io> fix naming of session keys (#4242) fix: revert restricted balances (#4237) fix: add missing spans in multisig logs (#4239) fix cargo features (#4249) fix: remove bound addresses on account deletion (#4244) fix: remove existential deposit (#4243) fix: egress id race condition (#4235) fix: remove unwrap when getting tx receipt (#4231) fix: protect against double witnessing after safe mode (#4254) fix: runtime upgrade utils and migrations (#4258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue brought up by Zellic