Fix the top level tests, fix a typo in the name. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the test was wrong, because I see the combo/backdoor/py_setuptools when I run this: ``` ➜ bincapz git:(fix-tests) ✗ go run . third_party/yara-rules-full.yar testdata/Python/valyrian_debug_setup.py | grep combo/backdoor 3/HIGH combo/backdoor/py_setuptools python library installer that executes external commands: "os.system( setup( setuptools" ``` And the other one seems like it does indeed just print `.` instead of the full path: ``` ➜ bincapz git:(fix-tests) ✗ go run . -diff testdata/macOS/libffmpeg.dirty.dylib testdata/macOS/libffmpeg.dylib Changed: . Previous Risk: 🚨 4/CRITICAL New Risk: ✅ 2/MEDIUM ``` Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
jedsalazar
approved these changes
Apr 3, 2024
egibs
pushed a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
Fix the top level tests, fix a typo in the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
Also the names of the tests were wrong so fixed those so it's easier to find where they came from.
I think the test was wrong, because I see the combo/backdoor/py_setuptools when I run this:
And the other one seems like it does indeed just print
.instead of the full path: