This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add support for apk.InstallPackages that assumes pre-resolved data. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imjasonh - could you please take a look at this proposal ? Thank you. |
sfc-gh-ptabor
force-pushed
the
20231208-split-executor
branch
3 times, most recently
from
16d90fa
to
a116d78
Compare
|
Ah I wish I had seen this before writing up this comment: chainguard-dev/apko#979 (comment) |
jonjohnsonjr
reviewed
Dec 8, 2023
sfc-gh-ptabor
force-pushed
the
20231208-split-executor
branch
from
b52e9e6
to
0c19238
Compare
This was referenced Dec 9, 2023
Support for locking packages to the versions from the 'apko.lock.json' file.
chainguard-dev/apko#979
Merged
jonjohnsonjr
approved these changes
Dec 11, 2023
|
I don't understand what's going on with golangci-lint, those failures seem incorrect. |
Thanks to this interface we can install packages based on pre-computed lock file. This guarantees fully hermetic and repeatable builds entirelly independent from APKINDEX payload. Signed-off-by: Piotr Tabor <piotr.tabor@snowflake.com>
sfc-gh-ptabor
force-pushed
the
20231208-split-executor
branch
from
b2a7863
to
5262b1d
Compare
Rebased on top of your PR. My local runs of clint are clean: |
imjasonh
approved these changes
Dec 12, 2023
imjasonh
pushed a commit
to chainguard-dev/rules_apko
that referenced
this pull request
Dec 31, 2023
… (re)builds. (#41) Integrate with apko-0.12+ . Pass `--lockfile` to apko to get hermetic (re)builds. This is `rules_apko` part of: #13 that integrates: - go-apk change: chainguard-dev/go-apk#172 - apko change: chainguard-dev/apko#979 --------- Signed-off-by: Piotr Tabor <piotr.tabor@snowflake.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to this interface we can install packages based on pre-computed lock file. This guarantees fully hermetic and repeatable builds entirelly independent from APKINDEX payload.
This is alternative (and IMHO the best solution) to chainguard-dev/rules_apko#13