Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it a reusable workflow, implement it and document it #844

Closed
Tracked by #785
javirln opened this issue May 29, 2024 · 1 comment · Fixed by chainloop-dev/labs#16 or chainloop-dev/labs#18
Closed
Tracked by #785
Assignees

Comments

@javirln
Copy link
Member

javirln commented May 29, 2024

The goal of the task is to provide a reusable workflow extract from the one introduced here: #822

With the following:

  • The reusable workflow needs to automatically onboard workflow if they don't exist by using the already existing reusable workflow: https://github.com/chainloop-dev/labs/blob/main/.github/workflows/chainloop_onboard.yml
  • It needs to expose the same optional parameters as the previous workflow.
  • It needs to accept a comma separated list of values as additional_materials that on top of the default materials being attested on the GitHub release, are added to the attestation.
  • Only the CHAINLOOP_TOKEN is a required input to the workflow.

Why string list of values? Because there is no array type on GitHub workflows. A comma separated values will be used.

Document all the process in docs.chainloop.dev guides section.

@migmartri
Copy link
Member

Makes sense to me. I'd make explicit that the only required parameter will be the CHAINLOOP_TOKEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants