Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

CMenu: Prefer emitting events over props as functions #146

Closed
4 tasks
codebender828 opened this issue May 2, 2020 · 0 comments · Fixed by #168
Closed
4 tasks

CMenu: Prefer emitting events over props as functions #146

codebender828 opened this issue May 2, 2020 · 0 comments · Fixed by #168
Labels
type: contributions welcome 💚 Contributions are welcome! type: feature or enhancement ⚡️ New feature or request

Comments

@codebender828
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The CMenu component currently accepts the onOpen and onClose function props.

However this goes against Vue's natural intuition and canbe better handled by emitting the @close and @open events to the parent context.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered

  • Change onClose prop to $emit('close')
  • Change onOpen prop to $emit('open')
  • Implement v-model for MenuGroup items.
  • Implement v-model for MenuList items with only MenuItems children
    to it's rendering performance have to be made in the CPopover component
@codebender828 codebender828 added type: contributions welcome 💚 Contributions are welcome! type: feature or enhancement ⚡️ New feature or request labels May 2, 2020
@codebender828 codebender828 changed the title Menu component should emit events CMenu: Perfer emitting events over props as functions May 2, 2020
@codebender828 codebender828 changed the title CMenu: Perfer emitting events over props as functions CMenu: Prefer emitting events over props as functions May 2, 2020
@codebender828 codebender828 mentioned this issue May 8, 2020
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: contributions welcome 💚 Contributions are welcome! type: feature or enhancement ⚡️ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant