Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number-input) build and test #1970

Merged
merged 5 commits into from
Sep 6, 2020
Merged

fix(number-input) build and test #1970

merged 5 commits into from
Sep 6, 2020

Conversation

TimKolberger
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Fixes build and test.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Build and test fails for NumberInput.

What is the new behavior?

  • Fix mismatching onChange prop for NumberInput by reverting commit a78a91b
  • Added correct a11y computation for aria-valuetext
  • Update test snapshot

Does this introduce a breaking change?

  • Yes
  • No

@vercel vercel bot temporarily deployed to Preview September 6, 2020 10:51 Inactive
@vercel
Copy link

vercel bot commented Sep 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/fi3t8ll7n
✅ Preview: https://chakra-ui-git-fork-timkolberger-fix-number-input-onchange.chakra-ui.vercel.app

@vercel vercel bot temporarily deployed to Preview September 6, 2020 10:56 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2020

This pull request introduces 1 alert when merging b6eccc2 into 75547b3 - view on LGTM.com

new alerts:

  • 1 for Non-linear pattern

@TimKolberger
Copy link
Contributor Author

Failing form-control test is fixed in #1972

@segunadebayo segunadebayo merged commit f2baf77 into chakra-ui:develop Sep 6, 2020
@with-heart with-heart added the Type: Bug 🐛 Something isn't working label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants