Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong styled prop types with jsxStyleProps set to none or minimal #2643

Closed
1 of 3 tasks
JohnnyCrazy opened this issue May 31, 2024 · 2 comments
Closed
1 of 3 tasks

Wrong styled prop types with jsxStyleProps set to none or minimal #2643

JohnnyCrazy opened this issue May 31, 2024 · 2 comments

Comments

@JohnnyCrazy
Copy link

Description

Hi,

When specifying jsxStyleProps: "none" | "minimal" in the panda.config.ts, typescript types are still generated as for jsxStyleProps: "all". The actual props do not have an effect, so it seems to be just on the type level.

Link to Reproduction

https://stackblitz.com/edit/vitejs-vite-82o8wx?file=src%2FApp.tsx&terminal=dev

Steps to reproduce

  1. Set jsxStyleProps: "none" | "minimal"
  2. Run panda codegen
  3. Use <styled.button p="4">Hello</styled.button>
  4. See how TS reports no problems, but the padding is not actually applied

JS Framework

React (TS)

Panda CSS Version

0.40.0

Browser

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

This was still working in version 0.37.2

@segunadebayo
Copy link
Member

I fixed this in the recent commit here

We'll release a new version shortly.

@JohnnyCrazy
Copy link
Author

Ah nice, thanks for the quick update! Will this also fix it for minimal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants