Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling tags or creating single tag #589

Open
rohit-gohri opened this issue May 14, 2021 · 6 comments
Open

Allow disabling tags or creating single tag #589

rohit-gohri opened this issue May 14, 2021 · 6 comments

Comments

@rohit-gohri
Copy link
Contributor

Affected Packages

pkg:@changesets/cli

Problem

I have a monorepo at https://github.com/rohit-gohri/redocusaurus where I'm using linked option to publish versions in sync for all packages. I want to create a single release in Github Releases when I release a new version, instead of individual releases for each package. But the tags generated currently are package wise.

Proposed solution

I would either like tags to not be created, so that I can create them manually on my own (currently I have to delete tags and make a new single one). Or switch to creating a single tag for linked packages.

@Andarist
Copy link
Member

Disabling tags would probably be easier, for now, especially design-wise. Changing how tags are created is a bigger topic that relates to some other topics, like this one: #537

I think we could bikeshed the topic more if you would prepare a PR for this. I think that we need to be able to filter out for which packages we want tags to be created - which includes:

  • disabling tags altogether
  • enabling them for all packages (public+private)
  • enabling them just for public packages (the default)
  • selective tagging using glob patterns

cc @mitchellhamilton

@nwalters512
Copy link

Would y'all accept a PR to just disable tag publishing as an easier, intermediate solution, or do you want to see a full selective tagging feature as described above?

@rohit-gohri
Copy link
Contributor Author

@nwalters512 I don't have any preference, I don't remember when but I switched to using the action which has a createGithubRelease option - changesets/action#87

@nwalters512
Copy link

@rohit-gohri it seems like that still creates the tags, it just doesn't create a corresponding release, is that correct?

@rohit-gohri
Copy link
Contributor Author

rohit-gohri commented May 22, 2024

@nwalters512 I just checked my code and disabling git tags was already added as a feature in #701 (maybe not documented in the best place) and I'm using that here already - https://github.com/rohit-gohri/redocusaurus/blob/863fe652a5372fc3b700b4e9f3e4a3efcf10363c/package.json#L15

So that part of the issue is already solved, but "selective tagging using glob patterns" would be ideal as it would allow me to remove the custom bash scripts for creating 1 single tag for the monorepo.

@nwalters512
Copy link

Nice! Between --no-git-tag and createGithubReleases: false, I'm all set now. Thanks for pointing those out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants