Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try do delete testing branch anymore #165

Closed
3 of 4 tasks
rudymatela opened this issue Aug 18, 2022 · 1 comment · Fixed by #173
Closed
3 of 4 tasks

Do not try do delete testing branch anymore #165

rudymatela opened this issue Aug 18, 2022 · 1 comment · Fixed by #173
Assignees
Labels
OKR Objectives and Key Results refactor Refactor train Involves Merge Trains

Comments

@rudymatela
Copy link

rudymatela commented Aug 18, 2022

In #134, we transitioned from testing on testing/<id> instead of just testing. In order to maintain backwards compatibility, we had to delete testing every time we created a new testing/<id> branch.

That has been a month ago, and most projects that use Hoff should have had at least one PR triggering the deletion of testing. So we should remove this code that tries deletion every time.

We currently see the following in the logs every time we merge:

Aug 18 13:37:12 hoff hoff[4321]: [Warn] error: git push -d failed. Reason: error: unable to delete 'testing': remote ref does not exist
Aug 18 13:37:30 hoff hoff[4321]: error: failed to push some refs to 'git@github.com:<org>/<repo>.git'

This should get rid of entries like the above.

TODO

  • check that all projects/repos do not have a testing branch anymore
    • delete any found
  • remove the testing deletion code: skip testing branch preemptive deletion #173
  • double-check that all projects/repos do not have a testing branch anymore
@rudymatela rudymatela added refactor Refactor OKR Objectives and Key Results train Involves Merge Trains labels Aug 18, 2022
@rudymatela rudymatela self-assigned this Aug 18, 2022
@rudymatela
Copy link
Author

Thanks to @tomwassenberg for helping me with the deletion in some repos! 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OKR Objectives and Key Results refactor Refactor train Involves Merge Trains
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant