Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable environment inheritance #14

Closed
duijf opened this issue Jul 3, 2017 · 1 comment
Closed

Add configuration option to disable environment inheritance #14

duijf opened this issue Jul 3, 2017 · 1 comment

Comments

@duijf
Copy link
Contributor

@duijf duijf commented Jul 3, 2017

Right now, vaultenv calls exec() and explicitly passes on the old environment so the process inherits this. Some people may not want this. We can add a CLI option to make this configurable, such as --no-pass-env.
Naming suggestions welcome.

Since there are currently no known cases where this might be useful, I'm waiting on at least one person to actually request this feature before implementing it. Please add a comment if you want this.

@arianvp
Copy link
Contributor

@arianvp arianvp commented Jul 3, 2017

Yes makes sense. Also if you have the case where you pass the vault token through VAULT_TOKEN you perhaps do not want to expose that to the running process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants